search

Thalassicus / cep-bnw

Civ V Communitas Expansion Pack
32 stars 22 forks source link

A few small issues #183

Closed EricB1 closed 10 years ago

EricB1 commented 10 years ago

These are a few updates to correct some minor issues.

First, the text for the Wealth finisher stated "Smithy" when that term isn't used anymore. Second, a few places in the code I noticed the word "receive" misspelled so I corrected it. Third, the Samurai unit was over-powered with a strength of 37. I lowered it to 28. Fourth, The Wheel tech should require Archery as a prerequisite. It's strange building Chariot Archers without Archery.

EricB1 commented 10 years ago

Longswords are 24 combat strength. I believe that Knights are 26. Arqubusiers are 24. Pikemen are 16 (I think, could be 18). Samurais also have a couple of free promotions (the Open Terrain promotion and the Blitz promotion). Also, with being in the UnitClass Longswordsman (that they already were), they get extra bonuses vs. cities. They are still a very powerful unit.

At 37 strength in the medieval era with those additional promotions, they were indestructible. So far I haven't found anyone in favor of keeping it at 37. It was basically a bug leftover from copying and pasting code from GEM. What worked in GEM doesn't always work in BNW.

GrantSP commented 10 years ago

Not sure about it being a leftover from GEM, more likely a change based on class or some other value that had strange results.

I think the changes should go through.

On 10 February 2014 12:23, EricB1 notifications@github.com wrote:

Longswords are 24 combat strength. I believe that Knights are 26. Arqubusiers are 24. Pikemen are 16. Samurais also have a couple of free promotions (the Open Terrain promotion and the Blitz promotion). Also, with being in the UnitClass Longswordsman (that they already were), they get extra bonuses vs. cities. They are still a very powerful unit.

At 37 strength in the medieval era with those additional promotions, they were indestructible. So far I haven't found anyone in favor of keeping it at 37. It was basically a bug leftover from copying and pasting code from GEM. What worked in GEM doesn't always work in BNW.

Reply to this email directly or view it on GitHubhttps://github.com/Thalassicus/cep-bnw/pull/183#issuecomment-34594478 .

"There are 10 types of people in the world: those who understand binary, and those who don't."

GrantSP commented 10 years ago

Overall I have no problems with these changes. If there are any difficulties any of them can easily be reverted.