Thalassicus / cep-bnw

Civ V Communitas Expansion Pack
32 stars 22 forks source link

Assyrian Siege Tower #207

Open GrantSP opened 10 years ago

GrantSP commented 10 years ago

There are 2 issues relating to this unit.

One was reported here a few months ago and the other by a user on CivFanatics.

1) #126 The ranged bonus is still applied to this unit. (I will close this and direct it to here.) 2) As a MELEE unit it is now rendered powerless with the changes made to PROMOTION_CITY_ASSAULT and other promotions as the bonuses we made to these are applied to SIEGE units.

I'm not really sure of the best way to tackle this. There are so many ways this needs to be handled. I believe we should revert any changes to bring it back as close to vanilla as possible as it is a very good unit in the vanilla game. Possibly making it a SIEGE unit would fix somethings but the promotions need a bit of adjusting also.

Any ideas are welcomed.

stackpoint commented 10 years ago

This promotion probably affects the Hunnic Battering Rams too.

Thalassicus commented 10 years ago

Battering ram already has the appropriate effects. I now copied those over to the Siege Tower. I also fixed the battering ram's promotion class (it was vanguard instead of soldier, locking out the siege promotion).

Thalassicus commented 10 years ago

Wait a moment... I noticed some inconsistencies, so I reverted back to the original siege tower data and performed a test. I placed one next to a barbarian city. It gets these attributes:

I hovered over the hostile city, and the unit panel indicated the correct combat bonus of +50% vs the city. The tower appears to get the correct attributes. The battering ram also appears correct, with the exception of the formerly mentioned promotion class I fixed.

What exactly is the problem?