Reapply PR #45 (lost in 3.4.6-rc) + Do not wait for StatefulSet when update strategy is OnDelete - Githubissues

ThalesGroup / helm-spray

Helm plugin for installing or upgrading sub-charts from an umbrella-chart using dependency orders

https://thalesgroup.github.io/helm-spray/

Apache License 2.0

74 stars 18 forks source link

Reapply PR #45 (lost in 3.4.6-rc) + Do not wait for StatefulSet when update strategy is OnDelete #59

Closed pamiel closed 4 years ago

pamiel commented 4 years ago

This PR targets version 3.x of Spray (i.e. Helm 2). It addresses the following:

Re-introduce updates previously pushed in PR https://github.com/ThalesGroup/helm-spray/pull/45 but lost in the 3.4.6-rc releases that will never be issued.
Do not wait for StatefulSet Pods re-deployment when StatefulSet update strategy is OnDelete (does not make any sense... and generate an infinite wait): addresses Issue https://github.com/ThalesGroup/helm-spray/issues/58

Both updates need to be forward-ported to version 4.x of Spray, i.e. for Helm 3 (subject to another PR).