ThalesGroup / security-risk-assessment-tool

The ISRA security-risk-assessment-tool project is an Electron based application used to do security risk assessments at a technical level
BSD 4-Clause "Original" or "Old" License
26 stars 8 forks source link

[Issue]: It is possible to select an invalid Supporting Asset in the Vulnerabilities Panel #224

Closed ThomasDThales closed 6 months ago

ThomasDThales commented 7 months ago

Issue Description

image

image

Duplicate Steps

Create a Supporting asset Don't associate any Business Asset Go to the Vulnerabilities Panel See the invalid Supporting asset selectable in the list

Expected Results

Display the invalid Supporting assets as red Invalid every vulnerability containing invalid supporting assets

Version Detected

1.1.0 (Default)

Attachments

No response

ThomasDThales commented 7 months ago

Expected Result: Invalid the Vulnerability + Display invalid Supporting asset in red

Alvin-JohnPagente commented 6 months ago

Is the supporting asset supposed to be red and not selectable?

In the Supporting Assets tab, should the invalid item be red like other tabs? image

Alvin-JohnPagente commented 6 months ago

Expected Result: Invalid the Vulnerability + Display invalid Supporting asset in red

The expected result in the bug description is different....

ThomasDThales commented 6 months ago

Is the supporting asset supposed to be red and not selectable?

In the Supporting Assets tab, should the invalid item be red like other tabs? image

see https://github.com/ThalesGroup/security-risk-assessment-tool/pull/235 for this matter

ThomasDThales commented 6 months ago

Expected Result: Invalid the Vulnerability + Display invalid Supporting asset in red

The expected result in the bug description is different....

Updated