search

Thalhammer / jwt-cpp

A header only library for creating and validating json web tokens in c++
https://thalhammer.github.io/jwt-cpp/
MIT License
899 stars 242 forks source link

📈 Improving OpenSSL test coverage #155

Closed prince-chrismc closed 3 years ago

prince-chrismc commented 3 years ago

We previously had a link against Travis CI who's old runners had provided coverage of 1.0.2u... Since @kleinmrk was so kind to add an openssl test workflow. I re-enabled the tests here and added badges.

I also renames the macros so they are less likely to have conflicts + bump libressl test versions

Here's the state of the tests

OpenSSL error test eddsa
1.0.2u ❌
[1.1.0i ✅
1.1.1k ✅ ✅
3.0.0-beta2 ✅ ✅
prince-chrismc commented 3 years ago

Oops! it seems there was branch permissions on the older versions of LibreSSL I removed. Can you please update them?

Thalhammer commented 3 years ago

Oops! it seems there was branch permissions on the older versions of LibreSSL I removed. Can you please update them?

Done, you might have to force push/add an additional commit though for github to pick it up on this pr. NVM Seems like my comment was enough.