search

Thalhammer / jwt-cpp

A header only library for creating and validating json web tokens in c++
https://thalhammer.github.io/jwt-cpp/
MIT License
899 stars 242 forks source link

Replace RSA related deprecated functions #189

Closed kleinmrk closed 2 years ago

kleinmrk commented 2 years ago

This MR replaces RSA related functions that are deprecated in OpenSSL 3.0.0 by non-deprecated alternatives.

Heads-up: The changes include adding values to signature_verification_error and signature_generation_error enums. This is a breaking change for code that does not use exceptions but error codes.

kleinmrk commented 2 years ago

@prince-chrismc thanks for the prompt review, I already addressed the cosmetic issues :+1:

prince-chrismc commented 2 years ago

Please do not force push 🙏 GitHub forces us to restart the review which is not fun!

Awesome, I'll merge this shortly 👍

kleinmrk commented 2 years ago

@prince-chrismc sorry, I did not know that it means extra work for you, I just tried to keep the history clean and compact. Lesson learned :+1:

Thalhammer commented 2 years ago

@prince-chrismc sorry, I did not know that it means extra work for you, I just tried to keep the history clean and compact. Lesson learned +1

Kepping the issue clean is not an issue, since we tend to squash merge anyway (Meaning all commits in the PR get crushed into a single merge commit in master). So they wont show up anywhere afterwards.