search

Thalhammer / jwt-cpp

A header only library for creating and validating json web tokens in c++
https://thalhammer.github.io/jwt-cpp/
MIT License
864 stars 235 forks source link

Do not embed nlohmann::json directly, use find_package / FetchContent instead #254

Closed sjanel closed 1 year ago

sjanel commented 1 year ago

Draft PR dealing with this issue

closes #250

prince-chrismc commented 1 year ago

thanks for this amazing PR ❤️

prince-chrismc commented 1 year ago

Please do not force push 🙏 GitHub forces us to restart the review which is not fun!

prince-chrismc commented 1 year ago

It's working as intended https://github.com/Thalhammer/jwt-cpp/actions/runs/3170117371/jobs/5166681733#step:11:1452

Install is picked no fetch content :rocket:

prince-chrismc commented 1 year ago

I'll hit merge assuming I didn't break it lol