search

Thalhammer / jwt-cpp

A header only library for creating and validating json web tokens in c++
https://thalhammer.github.io/jwt-cpp/
MIT License
828 stars 229 forks source link

Remove duplicated key handlers #318

Closed prince-chrismc closed 7 months ago

prince-chrismc commented 7 months ago

LoadPublicKeyFromStringReferenceWithEcCert

Trying to test https://github.com/Thalhammer/jwt-cpp/issues/186 to see if it's easy

prince-chrismc commented 7 months ago

in https://github.com/Thalhammer/jwt-cpp/pull/318/commits/5fd1ad9ad585e47d255dea3d8cd16d59d721b65b I noticed EdDSA is using a mixture of RSA and ECDSA error codes 😦

prince-chrismc commented 7 months ago

I feel the same way, I was considering fixing the eddsa keys being both RSA and EC -- the big think for 0.8.0 will likely be improving the error handling starting with #252 I am happy I did this because it gave me a better idea of what we have and need to possibly change :+1:

I was thinking of a proper cryoptographic_error to cover all of them similar to have there signature_verification and co.