ThanatosShinji / onnx-tool

A parser, editor and profiler tool for ONNX models.
https://pypi.org/project/onnx-tool/
MIT License
383 stars 51 forks source link

Have problem when profiling Twins, Swin and SwiftFormer #56

Closed vanlinhtruongdang closed 11 months ago

vanlinhtruongdang commented 11 months ago

Dear author,

I'm having trouble when profiling Twin Transformer (arxiv.org/abs/2104.13840), Swin Transformer (https://arxiv.org/abs/2103.14030), and SwiftFormer (https://arxiv.org/abs/2303.15446) while using similar methods with the previous issue (https://github.com/ThanatosShinji/onnx-tool/issues/55). The bug occurred with the original ONNX file which did not perform constant-folding, I think that there is a problem with the MOD operator or something else. The error has been described in the image and the ONNX file is attached below.

Hope to hear from you soon.

With SwiftFormer: image

With Twins and Swin: image

ONNX File: https://drive.google.com/drive/folders/1HahqFonb9zlGw2X6vQcqrL-K0FqaIXja?usp=share_link

ThanatosShinji commented 11 months ago

The twins and swin's issue has been fixed. But I can't reproduce the issue from SwiftFormer.

vanlinhtruongdang commented 11 months ago

So...what should I do now? Do you need its source code, your tool normally working with the constant-folding version of SwiftFormer but raises error with the original one? Will you fix it in the future or...I should change another model 😆

ThanatosShinji commented 11 months ago

You can profile these 3 models with the main branch code

Best Regards


From: Trương Đặng Văn Linh @.> Sent: Saturday, October 21, 2023 10:18:00 PM To: ThanatosShinji/onnx-tool @.> Cc: ThanatosShinji @.>; Comment @.> Subject: Re: [ThanatosShinji/onnx-tool] Have problem when profiling Twins, Swin and SwiftFormer (Issue #56)

So...what should I do now? Do you need its source code? Will you fix it in the future or...I should change another model 😆

— Reply to this email directly, view it on GitHubhttps://github.com/ThanatosShinji/onnx-tool/issues/56#issuecomment-1773805961, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZZIQRVCERLHMGVG6TLVWRDYAPKRRAVCNFSM6AAAAAA6KCMYSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTHAYDKOJWGE. You are receiving this because you commented.Message ID: @.***>

vanlinhtruongdang commented 11 months ago

It still raises error! I don't see any commit in term of fixing the bug with SwiftFormer. Do you miss something?

ThanatosShinji commented 11 months ago

With this head commit, I have no problem with SwiftFormer-S.onnx

ThanatosShinji commented 11 months ago

I see. the bug occurs without constant_folding

ThanatosShinji commented 11 months ago

The bug fix is done.

vanlinhtruongdang commented 11 months ago

I just turned on my computer to do work and your comment appeared as a salvation! Everything worked well, you are really talented and hardworking, I really appreciate it! Thank you for your efforts in the past 3 days, wish you success in your next projects <3