search

Thann / play-with-mpv

Chrome extension that allows you to play videos in webpages like youtube with MPV instead
https://chrome.google.com/webstore/detail/play-with-mpv/hahklcmnfgffdlchjigehabfbiigleji
The Unlicense
352 stars 81 forks source link

Does not work in Brave #50

Open luispabon opened 3 years ago

luispabon commented 3 years ago

When I press the button, nothing happens. There's no logs coming out of the server either. If I curl the server directly I do get a 400 error and a corresponding entry on the log for the server. It doesn't seem like the extension is even making the request.

I'm using all defaults - non-public, default port. I've checked the config for the browser extension and it matches.

There's no further logging on the brave console logs, if I start brave from a terminal.

Is there anything I can do to view logs for the extension itself somehow?

Ubuntu 20.04 Brave nightly 1.25.5 (Chromium 89) youtube-dl 2021.02.22 Python 3.8 play-with-mpv server 0.1.0.post8+g69beabf

Chaostheorie commented 3 years ago

I'm using it with brave ATM. You need to have the already running server in the background otherwise nothing will happen.

luispabon commented 3 years ago

As I mentioned, there's nothing coming on the logs of the running server. Meaning that the server is not receiving anything at all from brave and the extension.

Chaostheorie commented 3 years ago

@luispabon Does 'nothing' mean no incoming connections/ videos or does it mean literally nothing? I would expect at least to see something similar too serving on localhost:7531.

EDIT: I just noticed that using right click on a running video is, at least for me, flaky. Instead, try to use open-in-mpv over the context menu in the top-right corner for consistent results.

jvschiavo commented 3 years ago

It works for me in Brave. I just had to do this: https://github.com/Thann/play-with-mpv/issues/55#issuecomment-840979792