search

Thanood / Topshelf.Common.Logging

Common.Logging library bindings for Topshelf
Other
4 stars 4 forks source link

Update to Common.Logging 3.0 #1

Closed petersondrew closed 9 years ago

petersondrew commented 9 years ago

The API changes in Common.Logging 3.0 cause TypeLoadExceptions when calling UseCommonLogging() because it expects to find ILog in Common.Logging, rather than Common.Logging.Core. Recompiling Topshelf.Common.Logging against Common.Logging 3.0 resolves this issue.

The nuspec will need to be updated with a minimum Common.Logging version of 3.0 to reflect this change, along with a major version number change, however it isn't included in the repository so I could not make the changes myself.

cd21h commented 9 years ago

+1. Please merge this request. Thanks

petersondrew commented 9 years ago

@Thanood If you add the nuspec to the repository, I'd be happy to update that as well as part of this PR.

Thanood commented 9 years ago

Will do as soon as I can.. :-) Somehow I've managed to miss Common.Logging 3.

Thanood commented 9 years ago

The original nuspec is lost.. Will have to create a new one, sorry..