Topshelf 4.0 was released

[zendever]

Support for < 4.5.2 was removed, so need a new build that supports latest Topshelf. Pull Request coming, except that I couldn't sign the package when testing.

[JardarM]

Any plans to fix this?

[Thanood]

Sorry, totally forgot about this. I've had problems targetting multiple framework versions last time. I'll try to create a new version next week (busy atm)..

[JardarM]

Perfect. I had no problem building from source, so I got it working at least. But it would be nice to reference the nuget packet instead.

[Thanood]

I'm not sure if I should bump the major version. There's clearly no additional features or breaking changes but as the OP says support for .Net < 4.5.2 was removed so this would at least be an indicator for users of .Net < 4.5.2

Any thoughts?

[JardarM]

Hi

I have no strong oppinion about this. If it is closely tied to topshelf it might make sense to bump it to topshelf major number. Maybe it make sense to do it in the same way as the other more spesific libs are doing this? (Topshelf.log4net)

Jardar

7. jan. 2017 2:07 p.m. skrev "Daniel Bendel" notifications@github.com:

I'm not sure if I should bump the major version. There's clearly no additional features or breaking changes but as the OP says support for .Net < 4.5.2 was removed so this would at least be an indicator for users of .Net < 4.5.2

Any thoughts?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Thanood/Topshelf.Common.Logging/issues/3#issuecomment-271082866, or mute the thread https://github.com/notifications/unsubscribe-auth/AKatpu8C7M0QnFyBIikHl9FvwsJCO_98ks5rP44tgaJpZM4IaCJj .

[Thanood]

That would indeed make sense, especially if other TopShelf.*log* libraries do the same. Good idea, thanks! 👍

[Thanood]

Updated the NuGet package. Version number is now tied to TopShelf major version.

[JardarM]

Hi

Did you test it with Topshelf v 4.0.3?

I get the following error on the line: x.UseCommonLogging

Severity Code Description Project File Line Suppression State Error CS0012 The type 'HostConfigurator' is defined in an assembly that is not referenced. You must add a reference to assembly 'Topshelf, Version=4.0.0.0, Culture=neutral, PublicKeyToken=null'. Nortek.SeaServer.Decoder.Console C:\Dev\Code\NDSGit\source\Nortek\SeaServer\Decoder\Console\Program.cs 17 Active

[Thanood]

Actually I did test it with Topshelf v4.0.3.72.. I've used the TownCrier example from the docs (https://topshelf.readthedocs.io/en/latest/configuration/quickstart.html).

Maybe something is different if I pull from NuGet, I'll test again.

[Thanood]

Sorry, I forgot half about that stuff already and set the Topshelf reference to "specific version". 😕 Updated to a new version. It should work now.

[JardarM]

Perfect.

Best regards

Jardar

On Fri, Jan 13, 2017 at 2:30 PM, Daniel Bendel notifications@github.com wrote:

Sorry, I forgot half about that stuff already and set the Topshelf reference to "specific version". 😕 Updated to a new version. It should work now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Thanood/Topshelf.Common.Logging/issues/3#issuecomment-272443121, or mute the thread https://github.com/notifications/unsubscribe-auth/AKatpowDKJW5NvDuRbQw2kBZkFwUqyP5ks5rR3yEgaJpZM4IaCJj .

-- Jardar Maatje Nortek Data Services AS Brugata 1 0168 Oslo tlf: +47 95184034

[Thanood]

I hope it works when Topshelf v4.0.4 is released. 😃 Never experienced that problem with the 3.x versions.