search

ThanosFisherman / WifiUtils

Easily Connect to WiFi Networks
Apache License 2.0
734 stars 188 forks source link

Feature/disconnect improvement #66

Closed eliaslecomte closed 4 years ago

eliaslecomte commented 4 years ago

Description

There is actually a difference between disconnecting and removing the wifi configuration pre android 10.

Solution

Add 2 new methods, disconnect and remove. Also kept disconnectFrom so a major version bump isn't required.

eliaslecomte commented 4 years ago

Did you find any time to review this @ThanosFisherman ?

ThanosFisherman commented 4 years ago

No sorry @eliaslecomte couldn't find time. We are back at the office in my job and things are kind of crazy right now. Will try to review this during the weekend. Have you tested it yourself?

eliaslecomte commented 4 years ago

No sorry @eliaslecomte couldn't find time. We are back at the office in my job and things are kind of crazy right now. Will try to review this during the weekend. Have you tested it yourself?

No worries :-). I'll try test with multiple devices instead of just my own.

ThanosFisherman commented 4 years ago

@eliaslecomte Could you have a look at the comments above and make these minor corrections? Everything else seems good. Great job btw.

eliaslecomte commented 4 years ago

Yes I will, thx for reviewing!