Tharos / LeanMapper

Lean Mapper is a tiny ORM based on powerful Dibi database abstraction library for PHP.
MIT License
87 stars 35 forks source link

Update Tester and Docs #134

Open dakujem opened 5 years ago

dakujem commented 5 years ago

Changes:

Maybe some info about contribution can be added by you.

Also, what about the following sentence ??

"This library is no longer actively developed." ...

dakujem commented 5 years ago

Oh... okay. PHP 5.4 and 5.5 issue.

janpecha commented 5 years ago

I plan to drop PHP 5 support and update Tester in Lean Mapper 4.x.

For now IMHO would be fine add only contributing.md with instructions - how to create branch for PR, how to test changes (with list of required extensions), etc. Something like https://nette.org/en/contributing.

Composer commands

IMHO it's unnecessary because everybody needs something else - set another php.ini, run to coverage, Windows vs Unix issues, etc.

"This library is no longer actively developed." ...

I think we can remove it.

dakujem commented 5 years ago

That composer command test-local is very flexible and will work for most local environments (Win, Linux and Mac, provided they have composer installed) - all those extensions are pretty much standard for any local development. It is also super easy and even the lazy folks can run it. I personally prefer that to looking for a way to run the tests, then failing 5 times because of misspelled pathname, studying how nette Tester in particular is run (for newcommers) or similar issues.

Personally, I would only keep the local command as default for composer test, but I included that other one because I thought you were using the unix config.

janpecha commented 5 years ago

I thought about it and I have some notes.

So I think contributing manual is good idea but we don't need composer test.

dakujem commented 5 years ago

I agree with Tester v1.7 it does not bring the utility I had in mind and with upgrade to Tester v2 you lose support for legacy PHP. Though I think it is a good idea to just have composer test once you decide to move forward. It's just so easy to type composer test instead of path/to/my/vendor/some-binary some-options-why-uppercase-ffs.

janpecha commented 5 years ago

It would be great split this PR on 2 parts:

1) manual for contributors 2) changes in composer.json

We can add contributors manual in separate PR and this PR can wait for LM 4.x. What do you thing?

dakujem commented 5 years ago

@janpecha Good idea. How can i do that? Or will you?

janpecha commented 5 years ago

@dakujem I created #136. It's ok for you?

dakujem commented 5 years ago

I like it. Let's keep this one open until v4 (or close it, it's up to you, I don't mind).