Open dakujem opened 5 years ago
Oh... okay. PHP 5.4 and 5.5 issue.
I plan to drop PHP 5 support and update Tester in Lean Mapper 4.x.
For now IMHO would be fine add only contributing.md
with instructions - how to create branch for PR, how to test changes (with list of required extensions), etc. Something like https://nette.org/en/contributing.
Composer commands
IMHO it's unnecessary because everybody needs something else - set another php.ini, run to coverage, Windows vs Unix issues, etc.
"This library is no longer actively developed." ...
I think we can remove it.
That composer command test-local
is very flexible and will work for most local environments (Win, Linux and Mac, provided they have composer installed) - all those extensions are pretty much standard for any local development. It is also super easy and even the lazy folks can run it. I personally prefer that to looking for a way to run the tests, then failing 5 times because of misspelled pathname, studying how nette Tester in particular is run (for newcommers) or similar issues.
Personally, I would only keep the local command as default for composer test
, but I included that other one because I thought you were using the unix config.
I thought about it and I have some notes.
vendor/bin/tester -C
doesn't work in Tester 1.7 so test-local
is useless for nowvendor/bin/tester -c php-unix.ini
in composer.json
because in Tester 1.7 we need flexibility:
php.ini
for current environment-p php
, -p php5.6
or something else)composer install
3) run Tester - there are 2 options: composer test
or vendor/bin/tester <some arguments>
composer test
isn't flexibile in Tester 1.7 and is useless in Tester 2.x because there aren't big diferrences between composer test
and simple vendor/bin/tester -C
contributing.md
is better than one command line shortcutSo I think contributing manual is good idea but we don't need composer test
.
I agree with Tester v1.7 it does not bring the utility I had in mind and with upgrade to Tester v2 you lose support for legacy PHP. Though I think it is a good idea to just have composer test
once you decide to move forward. It's just so easy to type composer test
instead of path/to/my/vendor/some-binary some-options-why-uppercase-ffs
.
It would be great split this PR on 2 parts:
1) manual for contributors
2) changes in composer.json
We can add contributors manual in separate PR and this PR can wait for LM 4.x. What do you thing?
@janpecha Good idea. How can i do that? Or will you?
@dakujem I created #136. It's ok for you?
I like it. Let's keep this one open until v4 (or close it, it's up to you, I don't mind).
Changes:
-C
switch (see below)composer test
(run all tests)composer test-local
(run all tests using local PHP configuration, via the-C
Tester switch)Maybe some info about contribution can be added by you.
Also, what about the following sentence ??