search

Tharos / LeanMapper

Lean Mapper is a tiny ORM based on powerful Dibi database abstraction library for PHP.
MIT License
87 stars 35 forks source link

PHP 7.4 compatibility release #154

Closed vojtino closed 2 years ago

vojtino commented 3 years ago

Hi, please we would like just to ask when you will be releasing a version with PHP 7.4 compatibility. We saw commits to develop regarding the new PHP version. At least if you could give us some timeline estimate, it would be very helpful. Thank you very much.

janpecha commented 3 years ago

Hello. Have you any issue on PHP 7.4? Last stable release 3.4.1 should be compatible with PHP 7.4.

In develep branch are some commits for next big release 4.0. There is not any estimate for this next version.

vojtino commented 3 years ago

Hi, thank you for the prompt response. Well we have some warnings and notices when running php 7.4. Basically these notices come from dibi, because the 3.4.1 version of lean mapper is requiring version 3 of dibi. I presume this version of dibi is maybe not compatible with php 7.4?

vojtino commented 3 years ago

To be more precise: Trying to access array offset on value of type null File: .../vendor/dibi/dibi/src/Dibi/Fluent.php:466 466: $args = array_merge(['%lmt %ofs', $data['LIMIT'][0], $data['OFFSET'][0]], $args);

janpecha commented 3 years ago

I see, you are right. Bug is in Dibi, it was fixed in https://github.com/dg/dibi/commit/1db63d81e96540e3d8635c4e42312c81aeef8dfa.

If you can need use PHP 7.4 install Lean Mapper on commit c06199fe622d70a79b24f2495acecadfec7397b0 for now. There are some BC breaks after this commit.

BTW I created roadmap for Lean Mapper 4.0 (#155) - I hope version 4.0 will be released to end of year.

vojtino commented 3 years ago

Hi, thank you for your suggestion. It looks like it is working with the commit you proposed. Eagerly waiting for the new release 👍