search

ThatBatLuna / Beadi

https://beadi.onrender.com
BSD 3-Clause "New" or "Revised" License
11 stars 2 forks source link

problem with npm searching for a package.json inside of changelog.md when installing changelog dependency #7

Closed johnlong21 closed 1 year ago

johnlong21 commented 1 year ago

i was attempting to install and build a local version of beadi(i prefer to have things on my own system over using a browser), when trying to use npm install gave me this error:

npm ERR! code ENOTDIR
npm ERR! syscall open
npm ERR! path /home/johnlong/git-projects/Beadi/CHANGELOG.md/package.json
npm ERR! errno -20
npm ERR! ENOTDIR: not a directory, open '/home/johnlong/git-projects/Beadi/CHANGELOG.md/package.json'

thinking it might be because of my node version i switched to the latest version "19.4" but that did not work so i do not know what needs to be done to fix this.

node version:18.2.0 npm version:9.3.1

ThatBatLuna commented 1 year ago

Interesting, I knew this was a kinda weird thing I did, to display the current Changelog in the WelcomeNode.

I believe to temporarily fix this you can just remove the line 30 from the package.json "CHANGELOG": "file:./CHANGELOG.md" while doing the install, and re-add it later.

I am doing this weird thing, so that I can do this https://github.com/ThatBatLuna/Beadi/blob/2835e4fdce69ee77728e494b6d6aced02befc7c2/src/nodes/WelcomeNode.tsx#L6

I'll look into this^^

ThatBatLuna commented 1 year ago

Okay I can reproduce this with the versions you specified

ThatBatLuna commented 1 year ago

This should be fixed by c4f93216248fa04310700a8e3afdb12c7a903aa8 on the hotfix branch. If you could try it out and verify if it works, I'd be very glad.

johnlong21 commented 1 year ago

just confirmed and yes that commit seems to have fixed the problem

ThatBatLuna commented 1 year ago

Perfect, then I'll merge it to main!

Thank you a lot!