ThatConference / that-website

THAT Conference
https://www.thatconference.com
MIT License
32 stars 22 forks source link

Add client side validation for member slug #510

Closed brettski closed 4 years ago

brettski commented 4 years ago

When members initially create their profile they are able to choose a slug the want to use for their account. Currently only validate check is one on the api. It would be useful and a better experience for the user if there was a client side check as well.

Member slugs have the following whitelist (RegExp): /^[a-zA-Z0-9-_]+$/g Allowed are, letters, numbers, underscore and dash only.

The task here is to add a client-side check to notify user that they have entered an invalid slug.

image

jonathanurias96 commented 4 years ago

Hi brettski I would like to take this issue

brettski commented 4 years ago

Sounds fantastic! Thank you, we appreciate the help!

jonathanurias96 commented 4 years ago

Hi brettski, Problem I am having a request error when I try to enter into the login page in the site locally.

Screen Shot 2020-06-10 at 4 17 48 PM

Question Is there a way I can solve this?

Things to know

brettski commented 4 years ago

Yeah that’s an open issue we have. You are unable to access the auth server and we don’t have a way to do that for external devs at this time. We can’t expose our keys. Etc. We have not had the time to put together a solution for this. There are many pieces involved. Sorry for the trouble. If you have ideas we’re all ears.

jonathanurias96 commented 4 years ago

Got it, thanks. Im going to keep working on the validation issue.

jonathanurias96 commented 4 years ago

Ready for review

brettski commented 4 years ago

Fixed in PR #514