ThatConference / that-website

THAT Conference
https://www.thatconference.com
MIT License
32 stars 22 forks source link

Added conditional for ui slug validation #514

Closed jonathanurias96 closed 4 years ago

jonathanurias96 commented 4 years ago

510

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/that-conference/that-website/jo8ti1cp6 ✅ Preview: https://that-website-git-fork-jonathanurias96-master.that-conference.vercel.app

brettski commented 4 years ago

Hi @jonathanurias96. Your commit has linter errors. You can run npm run lint from the command line to verify. I am a bit surprised the hook didn't fire on push as well.

Errors reported: 07:54:00.756 [lint] /vercel/3ed8b157/components/Member/Profile/ContactInfo.js 07:54:00.756 [lint] 119:19 error 'userSlug' is never reassigned. Use 'const' instead prefer-const 07:54:00.756 [lint] 120:19 error 'isSlugValid' is never reassigned. Use 'const' instead prefer-const 07:54:00.756 [lint] 120:67 error Insert ; prettier/prettier 07:54:00.756 [lint] 126:17 error Assignment to property of function parameter 'errors' no-param-reassign

Thank you for all your time and efforts!

jonathanurias96 commented 4 years ago

Got it. I will make the adjustments and let you know when I have it ready.

jonathanurias96 commented 4 years ago

Ready for review

brettski commented 4 years ago

All checks passed! I pulled the branch down and ran it locally. The check doesn't seem to fire. I login with a new account and go to enter my profile information. On the first page I enter my first name, last name and profile slug. For Profile Slug I enter Brett$slaski and click off the field. The check should happen at this point but does not. The slug I entered doesn't satisfy the RegExp and the field should turn red with error message and does not.

I then tried to enter a slug I know already exists in the database and this did cause the field to show an error.

jonathanurias96 commented 4 years ago

Got it. I will keep working on it!

jonathanurias96 commented 4 years ago

Ready for review

brettski commented 4 years ago

Thank you @jonathanurias96! Please come join THAT Community in our slack channel: https://thatslack.thatconference.com