search

ThatConference / that-website

THAT Conference
https://www.thatconference.com
MIT License
32 stars 22 forks source link

Added functionality to the arrow icon to scroll down when clicked #518

Closed jonathanurias96 closed 4 years ago

jonathanurias96 commented 4 years ago

I believe this can solve the issue. Please review. If the animation is exactly what you where looking for, I can change it. Just let me know.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/that-conference/that-website/plhrhm7kf ✅ Preview: https://that-website-git-fork-jonathanurias96-master.that-conference.vercel.app

brettski commented 4 years ago

@saragibby Please review this pr and add any suggestions, etc. This UX is a bit out of my realm.

Brett

jonathanurias96 commented 4 years ago

Got it! Thank you. I will change it to that and let you know when I finish it.

jonathanurias96 commented 4 years ago

I added the changes in your suggestion @saragibby. It works. However, I noticed that when you click the "go back" button of the browser, it only scrolls you up. And only after clicking it again, it actually gets you to the previous page. Is this a problem for you guys? or that is the expected behavior?

saragibby commented 4 years ago

@jonathanurias96 the changes look great! I hear ya with the back in the browser feels a bit off, but we are going with it for now. We use it in a few places throughout the site, some as a stop gap until we build out a more complete page.

@brettski does this solve the issue you were hitting?

brettski commented 4 years ago

Thank you for your Help @jonathanurias96. It's very appreciated!

jonathanurias96 commented 4 years ago

443