search

ThatConference / that-website

THAT Conference
https://www.thatconference.com
MIT License
32 stars 22 forks source link

Root page event card link not working #553

Closed brettski closed 4 years ago

brettski commented 4 years ago

Describe the bug Links in event cards at the bottom do not work when clicked. You can right click and open in new tab, etc. but simply clicking the link doesn't take you anywhere.

To Reproduce Steps to reproduce the behavior:

  1. go to https://www.thatconference.com
  2. navigate to any of the current event cards (see visual aid)
  3. click link "THAT Online Tickets Now Available" or "Call for sponsors is now open" or "Call for sponsors now open!"
  4. Notice that clicking the link doesn't take you anywhere
  5. Right click the link and open in new window, you navigate to the desired page

Expected behavior Clicking the link should take you to that page.

image

saragibby commented 4 years ago

The bottom box with the highlight text is linking to the event, opening within the same tab. Has this already been fixed?

brettski commented 4 years ago

All of that navigation is a disaster after the pivot to the events landing page and not always using the router to determine event slug to use, etc. It does seem like these links do work now.

saragibby commented 4 years ago

Assuming the routing is a series of separate work, can this issue be closed since it is working?

brettski commented 4 years ago

Agreed, it can be closed

saragibby commented 4 years ago

Closing as item has already been completed.