ThatConference / that-website

THAT Conference
https://www.thatconference.com
MIT License
32 stars 22 forks source link

fix partner link. update contributors #570

Closed brettski closed 4 years ago

brettski commented 4 years ago

Description

Correct broken back to partners link in partner details page.

Fixes #542

Screenshots (if appropriate):

Types of changes

How Has This Been Tested?

I tested the bits locally, the site now goes back to the /partners page. This is a an okay fix until the routing is corrected for our different pages and we know where the partner pages will live. For example wi/2021/partners is valid, thought wi/2020/partners is not, we don't have a partners page there. Not knowing we can't simply use the event slug to show the partners page at this time. So the fix is to bring the user to the all partners page. Not optimal as they may not be going back to where they come from. Better than an error page though.

Checklist:

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/that-conference/that-website/8wstu4los ✅ Preview: https://that-website-git-brettski-fix-partner-link.that-conference.vercel.app

theClarkSell commented 4 years ago

📝Changed routes:

/partner/[slug]
Screenshot of /partner/[slug]
(view full size)

Commit 8f25c4bc46b1bfe20c1846c1bf98b658a66c0616 (https://that-website-git-brettski-fix-partner-link.that-conference.now.sh).