Az/558/toppartner storybook - Githubissues

ThatConference / that-website

THAT Conference

https://www.thatconference.com

MIT License

32 stars 22 forks source link

Az/558/toppartner storybook #622

Closed zaudtke closed 3 years ago

zaudtke commented 3 years ago

Description

Refactor Component to its own folder. Update Imports for new location. Add Spec file Add Story file.

Refactor Component to not export as styled as default, but rather create a styled component, add props, then export just the component.

Added JS file for Jest to treat prop type console.error messages as true errors to fail the tests.

Fixes #558

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Builds, passes tests, runs locally and storybook works. Verified still looks the same after making changes on how the component is now exported.

Checklist:

[ ] I have updated the documentation if necessary
[x] I have updated the stories as necessary
[x] I have updated the specs necessary

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/that-conference/that-website/3jggs1r9u
✅ Preview: https://that-website-git-az-558toppartner-storybook.that-conference.now.sh