Open ThatGirlJam opened 6 months ago
There is no error message indicating that the order did not go through. The order command did went through, and following up with the product command would complete the creation of the order. The error message of the product command then indicates to make sure that there is an existing item on the menu, which users can get from the UG how to add a product to the menu.
Team chose [response.Rejected
]
Reason for disagreement: Hello, thank you for your response.
However, I disagree. The error handling for adding an order (and subsequently the direction to proceed when the product does not go through) is not specific enough and can lead to confusion for new users.
As mentioned by the team's response, in adding an order, the order can go through despite there being no menu items to order from. There is no warning nor error message that the order can go through even if there are no items on the menu. This could lead to confusion for the user as to why the order
command is successful but product
is not -- or even confusion as to whether the order
command was even successful in the first place, and what will happen to the successfully/previously created order if the user is unable to add a product to it.
The design of this feature hence leads to a blurring of lines as to the functions of order
and product
, as an order can be initially created without a product yet the order is not displayed unless it has a product. To circumvent this, either the feature could have been designed to be clearer for the end-user or there could have been more specific error handling for the order
command when there are no products on the menu as well, similar to the error asking the user to check if there are existing items on the menu.
A clearer direction to proceed within the application itself rather than the users constantly referring to the UG would have been a helpful addition to prevent confusion as well.
Hence, I believe that this still constitutes a reasonable feature flaw, however I would like to revise its classification to severity.Low
, for the specificity and lack of an error message when an order is created despite there being no products/menu items.
I used the command "order p/87438807 by/08/04/2024" when there were no items on the menu. The error message was not specific in telling me that the order did not go through.
Tried to follow the existing message to add a product but unclear in what I am meant to do... also this format of "product m/[PRODUCT_ID] pq/[QUANTITY]" did not work since there are no menu items in the first place. There is no direction in how to proceed.