ThatOneCalculator / NerdFetch

A POSIX *nix fetch script using Nerdfonts
https://aur.archlinux.org/packages/nerdfetch/
MIT License
478 stars 24 forks source link

Better code #1

Closed eepykate closed 4 years ago

eepykate commented 4 years ago

Don't use /bin/bash, bash isn't required to be there.

. is the same as source but works in more places

basename is unbased, despite its name, just use "${var##*/}"

don't abuse variable search/replace... That's needlessly complicated

tput is a weird dependency that is not needed in the slightest, yet so many people still use it...