Picking colums in FloorPlans views

RASRC commented 1 year ago

Describe the bug 📝

I'm working in the Floor Plan viewer, and noticed that you cannot pick columns, even when I added the category using the classifier like in the documentation c0nlons3yjtdp0x9gv59hmzyiafa I can't select column elements by clicking. Instead, it selects the slab. Otherwise, I have no problems selecting any wall element by clicking. 72nva7rh953pqge1307imnes4a09 jsfhuxwgczwra8hk8st018u83s2f Thanks!

Reproduction ▶️

No response

Steps to reproduce 🔢

No response

System Info 💻

openbim-components

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a IFC.js components issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
[X] Check that this is a concrete bug. For Q&A join our Community.
[X] The provided reproduction is a minimal reproducible example of the bug.

Maozerhouni commented 1 year ago

I don't think it is a bug. It is more of an additionnal feature. Basically, the plan view is just a combination of a clipper and a camera position. When you clip object, it is in fact empty, even though filling style gives the inverse impression. So, when you click, the raycasting doesn't reach column. It instead reaches the slab.

RASRC commented 1 year ago

Hi @Maozerhouni! Thanks for the comment.

I understand your point but I can pick Walls without problems, wherever they are placed in the floorplan. In line with your explanation, they couldn't be pickable...

Maozerhouni commented 1 year ago

Oh ok. You're right. That s a bit odd. For the sake of experimentation, have you tried to tag walls as columns and vice versa ? I find it very weird that category Plays any role in this.

agviegas commented 1 year ago

Indeed, this is something we haven't implemented yet, but shouldn't be hard. I can bind the faces of the Edges Clipper to the IFC items to which they belong, thus enabling to pick clipped elements from above. I'll take care of it!

RASRC commented 7 months ago

Hi @agviegas ! Did you can implement the picking columns functionality for the Floor Plan viewer? Thanks.

agviegas commented 7 months ago

Hi! Not yet, sorry 😳 we are 3 people maintaining the whole thing plus also making the new features. I expect that next month we will have time to clean up the issues in this respository. Feel free to open a PR if it's an urgent matter.Thanks in advance for your patience! 🙏

agviegas commented 4 months ago

Progress

https://github.com/ThatOpen/engine_components/assets/56475338/58f5846f-6472-45d5-8a0d-422f3d62d4d3

agviegas commented 4 months ago

Done! Now we can select clipped elements. Available from @thatopen/components-front@2.0.15. Docs also updated, you can try it out in the plan tutorial example. Cheers!

ThatOpen / engine_components