Wrong y points of fragment plans when ifc length unit is in centimeters (too high) - Githubissues

ThatOpen / engine_components

MIT License

349 stars 134 forks source link

Wrong y points of fragment plans when ifc length unit is in centimeters (too high) #233

Closed robertbiskup closed 4 months ago

robertbiskup commented 11 months ago

Describe the bug 📝

I have some ifc projects in CENTI units (screen 2). I think this was not included in the algorithm in the IfcPropertiesUtils class in the getUnits method - there are METER and MILLI and missing CENTI and DECI

Reproduction ▶️

No response

Steps to reproduce 🔢

Load ifc with CENTI length units
Generate fragment plans

System Info 💻

"openbim-components": "1.2.0"

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
[X] Check that this is a concrete bug. For Q&A join our Community.
[X] The provided reproduction is a minimal reproducible example of the bug.

agviegas commented 4 months ago

Solved from 2.0.23. Let us know otherwise. Cheers!