ThatOpen / engine_components

MIT License
328 stars 129 forks source link

Culling doesn't behave correctly with tone mapping #3

Closed harrycollin closed 1 year ago

harrycollin commented 1 year ago

Fragment culling doesn't work when tone mapping is enabled on the renderer. This is likely due to the rendered frame not matching the RGB colours originally assigned. A simple fix is to set the renderer to use NoToneMapping before rendering the culling update. Alternatively we can create a new renderer specifically for culling.

Edit: this also applies when toneMappingExposure is not set to 1.0

harrycollin commented 1 year ago

Solved by giving the culling system it's own renderer https://github.com/IFCjs/components/commit/ab40254b7b0a877775b1b80dce030bf85a098750