ThatOpen / engine_components

MIT License
344 stars 135 forks source link

Allow to remove entities (for instance ifcDocumentReference and the related association) #502

Open TristanLecallierABIME opened 1 month ago

TristanLecallierABIME commented 1 month ago

Describe the bug 📝

The situation : I have an ifc with inside an ifcDocumentReference entity and some ifcElements related to it with an ifcRelAssociatesDocument association. I want to delete the ifcDocumentReference and also the relationship, and then save to ifc.

The issues :

Reproduction ▶️

No response

Steps to reproduce 🔢

No response

System Info 💻

"@thatopen/components": "^2.2.10",
"@thatopen/components-front": "^2.2.2",
"@thatopen/fragments": "^2.2.0",
"web-ifc": "0.0.57",

Used Package Manager 📦

pnpm

Error Trace/Logs 📃

No response

Validations ✅

HoyosJuan commented 1 week ago

Hey @TristanLecallierABIME!

I was taking a look at this the other day, and defined the best way to do it will require a breaking change in the indexation structure (meaning old-processed indexations won't be compatible with the new one). We avoid making breaking changes in minor versions, but for one single feature it doesn't make sense to create a new major version.

In case we don't find another way that integrates with the existing indexation structure (that is also efficient), we will wait until some other breaking changes to occur to group them all in one single major release 🙂

Will keep this updated!