search

ThatOpen / engine_web-ifc

Reading and writing IFC files with Javascript, at native speeds.
https://thatopen.github.io/engine_web-ifc/demo
Mozilla Public License 2.0
617 stars 190 forks source link

Wrong materials in 0.0.34 #143

Closed kovacsv closed 2 years ago

kovacsv commented 2 years ago

Online3DViewer regression tests failed after updating to web-ifc 0.0.34. The same error happens in the official demo as well.

Examples (0.0.33 vs. 0.0.34):

tomvandig commented 2 years ago

Cool, thanks for the notice!

agviegas commented 2 years ago

Hi @kovacsv! Can you please let us know where to find those files to fix it? Thanks!

kovacsv commented 2 years ago

Here they are: https://github.com/IFCjs/test-ifc-files/blob/main/Others/479l7.ifc https://github.com/IFCjs/test-ifc-files/blob/main/Others/haus.ifc

QuimMoya commented 2 years ago

We made some fixes and now we get similar results with other viewers. We will publish changes after reviewing.

agviegas commented 2 years ago

Solved here.