search

ThatOpen / engine_web-ifc

Reading and writing IFC files with Javascript, at native speeds.
https://thatopen.github.io/engine_web-ifc/demo
Mozilla Public License 2.0
617 stars 190 forks source link

Bad transformation matrix size should throw an error #221

Closed TxTony closed 1 year ago

TxTony commented 2 years ago

This could be better to throw an error.

https://github.com/IFCjs/web-ifc/blob/f68cee99b9e739937949097464d79ecf938a747c/src/web-ifc-api.ts#L335

https://github.com/IFCjs/web-ifc/blob/f68cee99b9e739937949097464d79ecf938a747c/src/web-ifc-api.ts#L281

TxTony commented 2 years ago

::take

agviegas commented 2 years ago

🟢🟢🟢

::take

Hi, @TxTony! Thanks for taking this bounty! The due date is November 5, 2022 UTC.

If you need to submit some pull requests (PR) to complete the tasks, make sure that the last and only the last PR has a title that either starts with the bounty ID or is exactly the same as the bounty name. After the PR is merged, this bounty’s status will automatically changed to done.

If you do not need to make a PR, tell the manager @agviegas to run ::done command after your tasks is confirmed to be done.

Good luck!

agviegas commented 1 year ago

::done

agviegas commented 1 year ago

🟢🟢🟢

::done

Hi, @TxTony! Thanks for your contributions! Please submit an expense to IFC.js Open Collective. Then, tell us the invoice number via the ::expense::_____ command (replace the _____ with the invoice number).