web-ifc is reloaded for every model

janruo commented 1 month ago

Describe the bug 📝

Every time fragmentIfcLoader.load() is called, it makes a new request to the 1.1 MB web-ifc wasm file.

The browser will most likely cache the request, and everything seems to be properly garbage collected anyway, so this shouldn't cause any real problems, but it still seems unnecessarily wasteful:

Reproduction ▶️

No response

Steps to reproduce 🔢

Call fragmentIfcLoader.load() more than once.

System Info 💻

@thatopen/components 2.0.6

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
[X] Check that this is a concrete bug. For Q&A join our Community.
[X] The provided reproduction is a minimal reproducible example of the bug.

agviegas commented 2 weeks ago

Maybe web-ifc can cache the WASM file once it has it. I'll move the issue there.

beachtom commented 1 week ago

This is fixed @agviegas somewhere in fragments something is callined ifcAPI.Init() multiple times. But I have added a check so even if it is called multiple times it will not download the wasm again

ThatOpen / engine_web-ifc