ThatOpen / engine_web-ifc

Reading and writing IFC files with Javascript, at native speeds.
https://thatopen.github.io/engine_web-ifc/demo
Mozilla Public License 2.0
573 stars 170 forks source link

[Bug]: Dimension marker not removed after measurement disabled #897

Closed MadsHolten closed 3 days ago

MadsHolten commented 4 days ago

What happened?

The little maker for LengthMeasurement, AreaMeasurement and AngleMeasurement is still shown in the dom after the tool has been disabled. This is still the case after the deleteAll and cancelCreation methods are executed.

The image below shows a scene where I have done a few measurements and disabled the measure tool + deleted all dimensions after each use (on esc key press event). The result is a whole little collection of red markers.

image

Version

0.54

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Anything else?

No response

MadsHolten commented 3 days ago

Moved to engine_components