Civil - can't read alignment

ThatOpen / engine_web-ifc

Reading and writing IFC files with Javascript, at native speeds.

https://thatopen.github.io/engine_web-ifc/demo

Mozilla Public License 2.0

603 stars 179 forks source link

Civil - can't read alignment #926

Closed SBrida closed 1 month ago

SBrida commented 3 months ago

Describe the bug 📝

i tried 3 files with alignement but the property Civil inside fragmenetgroup is empty. and an error unexpected mesh

Screenshot 2024-05-08 124318 Screenshot 2024-05-08 165313

Reproduction ▶️

No response

Steps to reproduce 🔢

No response

System Info 💻

openBim-componant 1.5

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
[X] Check that this is a concrete bug. For Q&A join our Community.
[X] The provided reproduction is a minimal reproducible example of the bug.

agviegas commented 3 months ago

Hey @SBrida would it be possible to share the file with us privately? My mail is antonio@thatopen.com, feel free to send a link there.

ervinalla99 commented 3 months ago

Since my issue is the same I am not opening a new one. I am sending to you a simple IFC with Alignment data. @agviegas

ervinalla99 commented 2 months ago

Since my issue is the same I am not opening a new one. I am sending to you a simple IFC with Alignment data. @agviegas

Sorry for bothering. Has this issue been identified yet and when can we expect to have it solved if it does not make it for the upcoming release? I wish I could contribute but I am just a Building Engineer with no coding experience :/

agviegas commented 2 months ago

Hi @ervinalla99! I have to check, but I think it has been solved. This weeks I have solved over 100 issues, but as you can imagine, I started with the older ones. I expect to solve the rest these days. Cheers

agviegas commented 1 month ago

I've double checked and indeed the issue is in the core not being able to read the alignment of this model correctly. I'm going to transfer this issue to the core repo!

ervinalla99 commented 1 month ago

@agviegas I think this is solved currently as I see the last commit , and every the IFC 4x3 I tried is parsed correctly here thatopen.github.io/engine_web-ifc/demo. However, when I load it in the engine template it is still empty (I replaced the web ifc folder with the current live version from github) What can be the reason?

agviegas commented 1 month ago

@ervinalla99 oh, I see! Let me update the dependency and see if it's solved

ervinalla99 commented 1 month ago

@agviegas I tried the last version of components and it works fine. Thanks a lot!