search

ThatOpen / web-ifc-three

The official IFC Loader for Three.js.
https://ifcjs.github.io/info/
MIT License
521 stars 133 forks source link

Last web-ifc implementation is not compatible with the last web-ifc-three implementation #149

Open jespa007 opened 1 year ago

jespa007 commented 1 year ago

Hi there,

If I try to build current implementation of web-ifc-three (i.e 0.0.122) with the lastest implementation of web-ifc it throws the following errors,

image

So web-ifc-three it has to be adapted with the latest changes of web-ifc, because some signatures were changed since web-ifc 0.0.36

jespa007 commented 1 year ago

@agviegas , I thing I've achieved make compatible last implementation web-ifc with last implementation of web-ifc-three. I'll make PR with the steps to update web-ifc in a while

jespa007 commented 1 year ago

@agviegas , I think it has no sense do a PR that makes compatibles to the last web-ifc, because people will still use web-ifc from npm and to build web-ifc, copy files is not easy task. But anyway, tell me if you are interested or not still in do the PR

beachtom commented 1 year ago

So there have been a few API changes to support multi-schema in the new web-ifc. My suggestion is wait for us to get the new version of web-ifc done then adapt web-ifc-three

jespa007 commented 1 year ago

So there have been a few API changes to support multi-schema in the new web-ifc. My suggestion is wait for us to get the new version of web-ifc done then adapt web-ifc-three

I agree with that @beachtom

agviegas commented 1 year ago

Agreed! Both web-ifc-three and web-ifc-viewer need a big update / clean up, so this might be a good opportunity.

olange commented 1 year ago

I opened IFCjs/web-ifc-viewer#188 a few minutes ago and discovered this one afterwards. I guess both are intermingled. This comment to cross-reference both.