search

ThatRozebudDude / FPS-Plus-Public

Other
123 stars 109 forks source link

SongMetaTags now get song data from meta.json #113

Closed soushimiya closed 1 month ago

soushimiya commented 1 month ago

also Restructured scriptable note class because it is redundant Changed CharacterInfoBase to CharacterInfo to match other script classes like Events, NoteTypes

ThatRozebudDude commented 1 month ago

If you're going to make multiple changes that are unrelated, please make multiple PRs. I don't think the restructuring you did is particularly necessary, but if you want to suggest it and explain why at least make it a separate PR instead. Also if you make a new PR with just the song meta stuff I'll probably accept it because I was planning on doing that at some point anyways,

soushimiya commented 1 month ago

ok