ThatXliner / lark_shell

[NOT ACTIVELY MAINTAINED] A terminal version of the online Lark IDE
GNU General Public License v3.0
2 stars 1 forks source link

Better internal error catching #5

Closed ThatXliner closed 3 years ago

ThatXliner commented 3 years ago

As described on roadmap #3

This will not catch all error but only up to LarkError.

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.73%.

Quality metrics Before After Change
Complexity 1.82 ⭐ 2.20 ⭐ 0.38 👎
Method Length 37.43 ⭐ 40.43 ⭐ 3.00 👎
Working memory 6.93 🙂 7.17 🙂 0.24 👎
Quality 80.67% 78.94% -1.73% 👎
Other metrics Before After Change
Lines 87 91 4
Changed files Quality Before Quality After Quality Change
lark_shell.py 80.67% ⭐ 78.94% ⭐ -1.73% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.