refactor ccd for better context manager usage

[w-samuelgauthier]

Changelog: changed

Description

Refactor ChargeCoupledDevice, AbstractCommunicator, WebsocketCommunicator, DeviceManager to allow better context manager usage.

• AbstractCommunicator regained a function to execute a command and get the response, response_from(Command) (it was already living in WebsocketCommunicator under the name execute_command(command_str, parameters_dict)
• The detection of connected devices is now done in a DeviceDiscovery class that is inside the DeviceManager and the ChargeCoupledDevices, Monochromator are directly instantiated inside the DeviceManager.

Related Issue

39

Type of Change

• [ ] 📚 Examples / docs / tutorials / dependencies update
• [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
• [ ] 🥂 Improvement (non-breaking change which improves an existing feature)
• [ ] 🚀 New feature (non-breaking change which adds functionality)
• [X] 💥 Breaking change (fix or feature that would cause existing functionality to change)
• [ ] 🔐 Security fix

Checklist

• [X] I've read the CODE_OF_CONDUCT.md document.
• [X] I've read the CONTRIBUTING.md guide.
• [X] I've updated the code style using make codestyle.
• [X] I've written tests for all new methods and classes that I created.
• [X] I've written the docstring in Google format for all the methods and classes that I used.

[w-samuelgauthier]

The cause of the failing unit tests with the HW, is due to the fact that DeviceManager is a singleton running its own event loop. The solution is to either:

• Remove the singleton annotation on DeviceManager and just make it non-singleton, the event loop from conftest.py can then be used
• Pass the event loop through the constructor of the DeviceManager

[ThatsTheEnd]

The cause of the failing unit tests with the HW, is due to the fact that DeviceManager is a singleton running its own event loop. The solution is to either:

• Remove the singleton annotation on DeviceManager and just make it non-singleton, the event loop from conftest.py can then be used
• Pass the event loop through the constructor of the DeviceManager

Hi Samuel, you genius, that you found out this fact. I don't particularly like to mess around with handling loops. I think this should be handled by the programming language itself. So my first attempt would be to remove the singleton annotation from the device handler. Kudos that you found the source of this behaviour!