search

Thaumic-Tinkerer / ThaumicTinkerer

A Spiritual Successor to the Elemental Tinkerer mod. This time Thaumcraft flavoured.
142 stars 121 forks source link

Osmotic Enchanter doesn't lose your settings when you add/remove a wand before starting enchantment #1054

Open SarahKirksey opened 2 years ago

SarahKirksey commented 2 years ago

I can't tell you how many times I've configured a tool or weapon with the perfect enchantment set, realized there's no wand in the table, and added a wand before clicking the button to start the enchantment. Every time, I died a little inside. I've spoken with others, and the ones who have also done this have agreed that this behavior is not desired. Since I was modifying the code to fix the Infused Seeds bugs, adding one more change to the mix was easy enough. So, I set the enchanter to stop scrubbing the configured enchantments every time the block is marked dirty.

GaeaKat commented 2 years ago

This one will need more testing before it is PR'd, as this is for an older version this will take more then a couple days. The previous behaviour was due to exploits that occurred, and I need to make sure it does not re-introduce them, or if people are having trouble, find a new way to patch

SarahKirksey commented 2 years ago

That's more than fair! Thank you for the prompt responses! Do you have any additional information regarding the nature of the exploits in question?