The-Academic-Observatory / academic-observatory-workflows

Telescopes, Workflows and Data Services for the Academic Observatory
https://academic-observatory-workflows.readthedocs.io
Apache License 2.0
16 stars 1 forks source link

Remove duplicate DOIs from Crossref Metadata #186

Closed jdddog closed 1 year ago

jdddog commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% :warning:

Comparison is base (064def5) 95.21% compared to head (cec0fee) 95.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #186 +/- ## =========================================== - Coverage 95.21% 95.20% -0.02% =========================================== Files 20 20 Lines 5206 5209 +3 Branches 719 720 +1 =========================================== + Hits 4957 4959 +2 Misses 161 161 - Partials 88 89 +1 ``` | [Files Changed](https://app.codecov.io/gh/The-Academic-Observatory/academic-observatory-workflows/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | Coverage Δ | | |---|---|---| | [academic\_observatory\_workflows/model.py](https://app.codecov.io/gh/The-Academic-Observatory/academic-observatory-workflows/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-YWNhZGVtaWNfb2JzZXJ2YXRvcnlfd29ya2Zsb3dzL21vZGVsLnB5) | `97.80% <100.00%> (+<0.01%)` | :arrow_up: | | [...ic\_observatory\_workflows/workflows/doi\_workflow.py](https://app.codecov.io/gh/The-Academic-Observatory/academic-observatory-workflows/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-YWNhZGVtaWNfb2JzZXJ2YXRvcnlfd29ya2Zsb3dzL3dvcmtmbG93cy9kb2lfd29ya2Zsb3cucHk=) | `93.75% <100.00%> (-0.35%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jdddog commented 1 year ago

Thanks Jamie. All of the UPPER(TRIM(doi)) statements in the create_doi script always annoyed me. Looks good.

Thanks. Haha they were annoying me too!