search

The-Academic-Observatory / academic-observatory-workflows

Telescopes, Workflows and Data Services for the Academic Observatory
https://academic-observatory-workflows.readthedocs.io
Apache License 2.0
16 stars 0 forks source link

Fix fetch wikipedia descriptions #217

Closed jdddog closed 4 months ago

jdddog commented 4 months ago

Fixed an issue in fetch_wikipedia_descriptions_batch, which was not returning descriptions for all input URLs in all cases. Specifically, when duplicate Wikipedia URLs were supplied and when two different URLs that point to the same page were supplied (e.g. one URL encoded and one not) .

Also added logging messages to print more info when there is a discrepancy between input URLs and output URLs.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.55%. Comparing base (a4954ad) to head (e5233c6).

Files Patch % Lines
academic_observatory_workflows/wikipedia.py 77.14% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #217 +/- ## ========================================== - Coverage 90.61% 90.55% -0.07% ========================================== Files 21 21 Lines 5170 5177 +7 Branches 750 749 -1 ========================================== + Hits 4685 4688 +3 - Misses 349 355 +6 + Partials 136 134 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.