The-Academic-Observatory / oaebu-workflows

Telescopes, Workflows and Data Services for the 'Book Analytics Dashboard Project (2022-2025)', building upon the project 'Developing a Pilot Data Trust for Open Access eBook Usage (2020-2022)'
https://documentation.book-analytics.org/
Apache License 2.0
5 stars 0 forks source link

Bad 241 - UCL Discovery data collection - Added ISBN10s #109

Closed alexmassen-hane closed 2 years ago

alexmassen-hane commented 2 years ago

Added column of "isbn" to the data pull because they are supposed to contain ISBN10s but sometimes also contain ISBN13s and vice versa. By adding this change, we can make a list of effected eprint IDs with dirty ISBNs that we can send to the publisher and request them to fix the errors.

codecov[bot] commented 2 years ago

Codecov Report

Merging #109 (80075ca) into develop (3160e37) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #109   +/-   ##
========================================
  Coverage    95.25%   95.25%           
========================================
  Files           23       23           
  Lines         2359     2359           
  Branches       302      302           
========================================
  Hits          2247     2247           
  Misses          55       55           
  Partials        57       57           
Impacted Files Coverage Δ
...ebu_workflows/workflows/ucl_discovery_telescope.py 98.34% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.