The-Academic-Observatory / oaebu-workflows

Telescopes, Workflows and Data Services for the 'Book Analytics Dashboard Project (2022-2025)', building upon the project 'Developing a Pilot Data Trust for Open Access eBook Usage (2020-2022)'
https://documentation.book-analytics.org/
Apache License 2.0
5 stars 0 forks source link

INF-550: Updated JSTOR transform for new report format #114

Closed keegansmith21 closed 2 years ago

keegansmith21 commented 2 years ago

JSTOR report format has changed in the following ways:

These changes break our workflow, so I have adjusted the telescope's transform function such that the original headings are retained

codecov[bot] commented 2 years ago

Codecov Report

Base: 94.82% // Head: 94.95% // Increases project coverage by +0.12% :tada:

Coverage data is based on head (a836353) compared to base (1173302). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #114 +/- ## =========================================== + Coverage 94.82% 94.95% +0.12% =========================================== Files 23 23 Lines 2627 2635 +8 Branches 338 340 +2 =========================================== + Hits 2491 2502 +11 + Misses 70 68 -2 + Partials 66 65 -1 ``` | [Impacted Files](https://codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | Coverage Δ | | |---|---|---| | [oaebu\_workflows/workflows/jstor\_telescope.py](https://codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9qc3Rvcl90ZWxlc2NvcGUucHk=) | `90.83% <100.00%> (+0.31%)` | :arrow_up: | | [oaebu\_workflows/workflows/onix\_workflow.py](https://codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9vbml4X3dvcmtmbG93LnB5) | `93.22% <0.00%> (+0.48%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.