The-Academic-Observatory / oaebu-workflows

Telescopes, Workflows and Data Services for the 'Book Analytics Dashboard Project (2022-2025)', building upon the project 'Developing a Pilot Data Trust for Open Access eBook Usage (2020-2022)'
https://documentation.book-analytics.org/
Apache License 2.0
5 stars 0 forks source link

Onix keyword null ammendment #127

Closed keegansmith21 closed 1 year ago

keegansmith21 commented 1 year ago

The Oapen onix workflow is running into issues with the book_product table creation. This appears to be because of the Subjects.SubjectHeadingText column of the Onix table - which is null-filled due to the absence of data from Oapen's XML metadata file. This PR slightly alters the SQL template that creates the book product table so that there are no issues with the SubjectHeadingText column being null-filled.

Big thanks to @JulianTonti for helping with the solution.

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.76% // Head: 94.76% // No change to project coverage :thumbsup:

Coverage data is based on head (ef7c732) compared to base (a475599). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #127 +/- ## ======================================== Coverage 94.76% 94.76% ======================================== Files 23 23 Lines 2655 2655 Branches 344 344 ======================================== Hits 2516 2516 Misses 67 67 Partials 72 72 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.