The-Academic-Observatory / oaebu-workflows

Telescopes, Workflows and Data Services for the 'Book Analytics Dashboard Project (2022-2025)', building upon the project 'Developing a Pilot Data Trust for Open Access eBook Usage (2020-2022)'
https://documentation.book-analytics.org/
Apache License 2.0
5 stars 0 forks source link

Updated filenames in dag to use telescope default #131

Closed keegansmith21 closed 1 year ago

keegansmith21 commented 1 year ago

The onix table name derives from the file names used to create them. It is therefore imperative that the files are correctly named. The file names were recently updated on the telescope, but I forgot to update them as they are passed from the dag creation. I think that it is better to have the dag simply use the default of the telescope to avoid this in future.

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.93% // Head: 94.93% // No change to project coverage :thumbsup:

Coverage data is based on head (183be6c) compared to base (7c4ceaf). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #131 +/- ## ======================================== Coverage 94.93% 94.93% ======================================== Files 23 23 Lines 2707 2707 Branches 353 353 ======================================== Hits 2570 2570 Misses 64 64 Partials 73 73 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.