The-Academic-Observatory / oaebu-workflows

Telescopes, Workflows and Data Services for the 'Book Analytics Dashboard Project (2022-2025)', building upon the project 'Developing a Pilot Data Trust for Open Access eBook Usage (2020-2022)'
https://documentation.book-analytics.org/
Apache License 2.0
5 stars 0 forks source link

Remove helper functions from Thoth telescope #134

Closed alexmassen-hane closed 1 year ago

alexmassen-hane commented 1 year ago

Removing the helper functions from the Thoth Telescope to the common Observatory Platform space.

The unit tests of this PR will fail until the following PR is merged: https://github.com/The-Academic-Observatory/observatory-platform/pull/607

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.94% // Head: 95.00% // Increases project coverage by +0.06% :tada:

Coverage data is based on head (cbd815c) compared to base (ad042a5). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #134 +/- ## =========================================== + Coverage 94.94% 95.00% +0.06% =========================================== Files 23 23 Lines 2709 2682 -27 Branches 355 351 -4 =========================================== - Hits 2572 2548 -24 + Misses 64 62 -2 + Partials 73 72 -1 ``` | [Impacted Files](https://codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | Coverage Δ | | |---|---|---| | [oaebu\_workflows/workflows/thoth\_telescope.py](https://codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy90aG90aF90ZWxlc2NvcGUucHk=) | `89.68% <100.00%> (+0.14%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.