search

The-Academic-Observatory / oaebu-workflows

Telescopes, Workflows and Data Services for the 'Book Analytics Dashboard Project (2022-2025)', building upon the project 'Developing a Pilot Data Trust for Open Access eBook Usage (2020-2022)'
https://documentation.book-analytics.org/
Apache License 2.0
5 stars 0 forks source link

Fix GA schema find #153

Closed keegansmith21 closed 1 year ago

keegansmith21 commented 1 year ago

The google analytics find_schema needs to search foir the organisation name prefix. Otherwise it'll find the base schema which leads to bigquery loading errors

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1b0073f) 95.09% compared to head (a0d8191) 95.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #153 +/- ## ======================================== Coverage 95.09% 95.09% ======================================== Files 16 16 Lines 2405 2408 +3 Branches 317 317 ======================================== + Hits 2287 2290 +3 Misses 73 73 Partials 45 45 ``` | [Impacted Files](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | Coverage Δ | | |---|---|---| | [...\_workflows/workflows/google\_analytics\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9nb29nbGVfYW5hbHl0aWNzX3RlbGVzY29wZS5weQ==) | `90.90% <100.00%> (+0.13%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.