The-Academic-Observatory / oaebu-workflows

Telescopes, Workflows and Data Services for the 'Book Analytics Dashboard Project (2022-2025)', building upon the project 'Developing a Pilot Data Trust for Open Access eBook Usage (2020-2022)'
https://documentation.book-analytics.org/
Apache License 2.0
5 stars 0 forks source link

Added fulcrum to data export SQL #158

Closed keegansmith21 closed 1 year ago

keegansmith21 commented 1 year ago

Fulcrum data was missing from the SQL that makes the data export tables. I've added it in so that it's part of the tables that create the final dashboards.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (9dcb229) 95.09% compared to head (eba2a7e) 95.09%.

:exclamation: Current head eba2a7e differs from pull request most recent head 080b56a. Consider uploading reports for the commit 080b56a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #158 +/- ## =========================================== - Coverage 95.09% 95.09% -0.01% =========================================== Files 16 16 Lines 2408 2407 -1 Branches 317 317 =========================================== - Hits 2290 2289 -1 Misses 73 73 Partials 45 45 ``` | [Impacted Files](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | Coverage Δ | | |---|---|---| | [oaebu\_workflows/workflows/onix\_workflow.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9vbml4X3dvcmtmbG93LnB5) | `96.37% <ø> (-0.01%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kathrynnapier commented 1 year ago

Thanks @keegansmith21 ! Very minor comment- I'm currently working on updating read the docs (review to come to you soon), and am looking at renaming OAPEN Irus uk to IRUS OAPEN - how it's now named on the jisc website, https://irus.jisc.ac.uk/r5/oapen/, and Fulcrum to IRUS Fulcrum.

Is it worth changing the schema descriptions:

"Metrics from IRUS-UK" to "Metrics from IRUS OAPEN" "Metrics from Fulcrum" to "Metrics from IRUS Fulcrum"

keegansmith21 commented 1 year ago

Thanks @kathrynnapier I really like the idea of a rename. I think it's probably outside the scope of this PR as it would involve changing their respective telescopes and the onix workflow. I'll make a new PR once this one is merged.