Closed keegansmith21 closed 1 year ago
Patch coverage has no change and project coverage change: -0.01
:warning:
Comparison is base (
9dcb229
) 95.09% compared to head (eba2a7e
) 95.09%.:exclamation: Current head eba2a7e differs from pull request most recent head 080b56a. Consider uploading reports for the commit 080b56a to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @keegansmith21 ! Very minor comment- I'm currently working on updating read the docs (review to come to you soon), and am looking at renaming OAPEN Irus uk to IRUS OAPEN - how it's now named on the jisc website, https://irus.jisc.ac.uk/r5/oapen/, and Fulcrum to IRUS Fulcrum.
Is it worth changing the schema descriptions:
"Metrics from IRUS-UK" to "Metrics from IRUS OAPEN" "Metrics from Fulcrum" to "Metrics from IRUS Fulcrum"
Thanks @kathrynnapier I really like the idea of a rename. I think it's probably outside the scope of this PR as it would involve changing their respective telescopes and the onix workflow. I'll make a new PR once this one is merged.
Fulcrum data was missing from the SQL that makes the data export tables. I've added it in so that it's part of the tables that create the final dashboards.