The-Academic-Observatory / oaebu-workflows

Telescopes, Workflows and Data Services for the 'Book Analytics Dashboard Project (2022-2025)', building upon the project 'Developing a Pilot Data Trust for Open Access eBook Usage (2020-2022)'
https://documentation.book-analytics.org/
Apache License 2.0
5 stars 0 forks source link

Updated oapen metadata to work with additional OAPEN data sources #166

Closed keegansmith21 closed 1 year ago

keegansmith21 commented 1 year ago

OAPEN Metadata Telescope Update

This PR updates the OAPEN Metadata telescope with one additional line of functionality - the ability to change the source URI of the metadata. This has become necessary as the BTOB collection (and upcoming SHMP collection) will host their metadata on the OAPEN platform. This change in itself was not substantial, the majority of the altered code has been a refactor of how the xmls are handled and how invalid products are removed from them. I have also updated the tests to be more verbose.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 96.73% and project coverage change: +0.09% :tada:

Comparison is base (7e7aae2) 95.13% compared to head (465dc20) 95.23%. Report is 3 commits behind head on develop.

:exclamation: Current head 465dc20 differs from pull request most recent head 849560c. Consider uploading reports for the commit 849560c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #166 +/- ## =========================================== + Coverage 95.13% 95.23% +0.09% =========================================== Files 16 16 Lines 2426 2413 -13 Branches 316 313 -3 =========================================== - Hits 2308 2298 -10 + Misses 72 71 -1 + Partials 46 44 -2 ``` | [Files Changed](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | Coverage Δ | | |---|---|---| | [...bu\_workflows/workflows/oapen\_metadata\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9vYXBlbl9tZXRhZGF0YV90ZWxlc2NvcGUucHk=) | `97.15% <96.73%> (+1.39%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.