The-Academic-Observatory / oaebu-workflows

Telescopes, Workflows and Data Services for the 'Book Analytics Dashboard Project (2022-2025)', building upon the project 'Developing a Pilot Data Trust for Open Access eBook Usage (2020-2022)'
https://documentation.book-analytics.org/
Apache License 2.0
5 stars 0 forks source link

OaebuPartner Class Expansion #187

Closed keegansmith21 closed 1 year ago

keegansmith21 commented 1 year ago

This PR expands on the OaebuPartner class and shifts around (and renames) partner-specific schemas.

This is the first step in an effort to pull partner-specific logic from the main workflow and queries.

As part of this change, I have also done some housekeeping:

Deployment Notes

codecov[bot] commented 1 year ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (28b2714) 95.19% compared to head (85e5d5f) 95.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #187 +/- ## =========================================== - Coverage 95.19% 95.03% -0.17% =========================================== Files 16 16 Lines 2395 2378 -17 Branches 313 311 -2 =========================================== - Hits 2280 2260 -20 - Misses 71 72 +1 - Partials 44 46 +2 ``` | [Files](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | Coverage Δ | | |---|---|---| | [oaebu\_workflows/config.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL2NvbmZpZy5weQ==) | `100.00% <ø> (ø)` | | | [...aebu\_workflows/workflows/google\_books\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9nb29nbGVfYm9va3NfdGVsZXNjb3BlLnB5) | `94.30% <100.00%> (-0.08%)` | :arrow_down: | | [...aebu\_workflows/workflows/irus\_fulcrum\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9pcnVzX2Z1bGNydW1fdGVsZXNjb3BlLnB5) | `98.33% <100.00%> (-0.05%)` | :arrow_down: | | [oaebu\_workflows/workflows/irus\_oapen\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9pcnVzX29hcGVuX3RlbGVzY29wZS5weQ==) | `97.60% <100.00%> (-0.03%)` | :arrow_down: | | [oaebu\_workflows/workflows/jstor\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9qc3Rvcl90ZWxlc2NvcGUucHk=) | `94.83% <100.00%> (-0.04%)` | :arrow_down: | | [...bu\_workflows/workflows/oapen\_metadata\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9vYXBlbl9tZXRhZGF0YV90ZWxlc2NvcGUucHk=) | `97.12% <100.00%> (-0.02%)` | :arrow_down: | | [oaebu\_workflows/workflows/onix\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9vbml4X3RlbGVzY29wZS5weQ==) | `94.91% <100.00%> (-0.09%)` | :arrow_down: | | [oaebu\_workflows/workflows/onix\_workflow.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9vbml4X3dvcmtmbG93LnB5) | `95.67% <100.00%> (-0.13%)` | :arrow_down: | | [oaebu\_workflows/workflows/thoth\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy90aG90aF90ZWxlc2NvcGUucHk=) | `97.67% <100.00%> (-0.03%)` | :arrow_down: | | [...ebu\_workflows/workflows/ucl\_discovery\_telescope.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy91Y2xfZGlzY292ZXJ5X3RlbGVzY29wZS5weQ==) | `100.00% <100.00%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/187?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.