codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
c1dedc4) 95.19% compared to head (38244bc) 95.20%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #188 +/- ## ======================================== Coverage 95.19% 95.20% ======================================== Files 16 16 Lines 2395 2396 +1 Branches 312 312 ======================================== + Hits 2280 2281 +1 Misses 71 71 Partials 44 44 ``` | [Files Changed](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory) | Coverage Δ | | |---|---|---| | [oaebu\_workflows/workflows/onix\_workflow.py](https://app.codecov.io/gh/The-Academic-Observatory/oaebu-workflows/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The-Academic-Observatory#diff-b2FlYnVfd29ya2Zsb3dzL3dvcmtmbG93cy9vbml4X3dvcmtmbG93LnB5) | `95.79% <100.00%> (+<0.01%)` | :arrow_up: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We changed the field to page_views from unique_views in #95. We now need access to either the unique OR page views depending on the publisher. To accomplish this, I altered the book_product sql to template out the google_analytics views field. This requires the views_field to be supplied when rendering - it defaults to page_views in the ONIX_WF telescope.
Note - we'll have to add the ga3_views_field to the config file ONIX WFs that contain google_analytics as data partner.